Skip to content

Fix sort_index #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix sort_index #245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7fce3
Add test for sort_index correctness
kojix2 Sep 10, 2025
3271e12
Fix sporadic misordering in sort_index on GCC 13+ by forcing byte-wis…
kojix2 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/numo/narray/gen/tmpl/qsort.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ static void
presorted;

loop:SWAPINIT(a, es);
if (es >= sizeof(void*)) swaptype = 2;
if (n < 7)
{
for (pm = (char *) a + es; pm < (char *) a + n * es; pm += es)
Expand Down
6 changes: 6 additions & 0 deletions test/narray_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,4 +649,10 @@ class NArrayTest < Test::Unit::TestCase
assert_equal(Numo::DFloat[1, Float::NAN, 3].format_to_a,
Numo::DFloat.cast(Numo::RObject[1, nil, 3]).format_to_a)
end

test "sort_index correctness" do
a = Numo::SFloat.new(10).rand_norm
idx = a.sort_index
assert { a[idx].to_a == a[idx].to_a.sort }
end
end
Loading