This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Fixes bignum conversions#246
Open
bkabrda wants to merge 1 commit intorubyjs:masterfrom
bkabrda:master
Open
Conversation
Collaborator
|
@bkabrda Thanks for the PR! To make sure this gets merged, can you please provide a test? One that demonstrates the current deficiency. |
Author
|
Actually, it breaks "Fixnum for 64 bit numbers" and "Fixnum should convert negative integer" specs added in 1aed745, when running on 32 bit machine (using Ruby 2.0.0). That's how I found the issue in the first place. |
Collaborator
|
I'd like to get this merged, but I'm a bit uncomfortable with a spec that only breaks on 32bit machines since that accounts for a very small portion of the machines running the tests, including the CI server. |
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty much the same as PR #182, just for Bignum.