This repository was archived by the owner on Dec 4, 2023. It is now read-only.
Change names access helper to iterate over the ancestors instead of doing dup/shift#410
Open
TikiTDO wants to merge 1 commit intorubyjs:masterfrom
Open
Change names access helper to iterate over the ancestors instead of doing dup/shift#410TikiTDO wants to merge 1 commit intorubyjs:masterfrom
TikiTDO wants to merge 1 commit intorubyjs:masterfrom
Conversation
…oing dup/shift Due to setup of the helper calling the get or set methods on any object bound to a ruby object will call the accessibe_names each time. This will result in the creation of an new array which will be used for iteration and then discarded, which is quite inefficient if you plan on calling into ruby often.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to setup of the helper calling the get or set methods on any js object bound to a ruby object will call the accessibe_names each time. This will result in the duplication of the ancestors array which will be used for iteration and then discarded, which is quite inefficient if you plan on calling into ruby often.
Note, an identical and even faster effect could be achieved by refactoring the class to testing where a method is defined using a process like this:
I can implement the change if there is interest.