Integrate AppserviceUserIdentity

[rsb-tbg]

This PR adds support for AppserviceUserIdentity in appservice requests and introduces the SupportedPathBuilder trait to handle different PathBuilder types.

Changes:

• Add SupportedPathBuilder trait for VersionHistory and SinglePath path builders
• Update send_request_as to accept AppserviceUserIdentity instead of &UserId
• Add send_customized_request_as function in lib.rs
• Removed send_customized_matrix_request from HttpClientExt and send_customized_request method from Client
• Add C::RequestBody: AsRef<[u8]> bounds required by ruma's try_into_http_request

Breaking changes documented in CHANGELOG.md.

[Copilot]

Pull Request Overview

This PR integrates AppserviceUserIdentity support for application service requests and introduces the SupportedPathBuilder trait to enable flexible handling of different path builder types (VersionHistory and SinglePath).

Key Changes:

• Introduced SupportedPathBuilder trait to abstract path builder input handling across different PathBuilder implementations
• Updated send_request_as to accept AppserviceUserIdentity instead of &UserId for better appservice support
• Replaced manual query parameter manipulation with ruma's built-in try_into_http_request_with_identity method
• Added C::RequestBody: AsRef<[u8]> bounds required by ruma's request conversion functions

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/lib.rs	Refactored request sending functions to use new authentication and path builder inputs; added send_customized_request_as for appservice requests
src/http_client.rs	Updated HttpClientExt trait methods to accept path builder inputs and AppserviceUserIdentity; removed deprecated customization methods
src/client/builder.rs	Added C::RequestBody: AsRef<[u8]> bounds and updated path builder input from &SupportedVersions to () for SinglePath compatibility
src/client.rs	Introduced SupportedPathBuilder trait with implementations for VersionHistory and SinglePath; updated client methods with new bounds
CHANGELOG.md	Documented breaking changes and improvements for this release

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zecakeh]

Could we split this into 2 PRs? The first one just upgrades Ruma, and the second one integrates AppserviceUserIdentity.

[rsb-tbg]

Will do! I'll be offline for a couple weeks but will fix it up afterwards.

For the first PR, what version should I upgrade ruma to?

[zecakeh]

Since we had a new release of Ruma, I opened #19 to upgrade Ruma. You'll just need to rebase your AppserviceUserIdentity changes on top of it.

[rsb-tbg]

How's this look? Happy to modify, just let me know. All advice is welcomed 😄

[zecakeh]

This looks better overall. Could you avoid unnecessary changes like renaming function arguments and lifetimes, to reduce the diff?

[zecakeh]

Thanks, I just have a couple of nits left.

[jplatte]

@rsb-tbg hey, is this Copilot review thing something you enabled knowingly? Could you please disable it for your PRs to our project? We do not accept LLM contributions as per our contributing guide.

[rsb-tbg]

Hey @jplatte, no I didn't enable anything. I do see the comments from 2 weeks ago from copilot now that you mention it. I'll check my settings and see if I can disable whatever it is. Sorry about that.

[jplatte]

No worries. I would assume you can disable it here.

[rsb-tbg]

Yup, already turned it off. I'll keep an eye on it for next time. Thanks

[zecakeh]

I am sorry to tell you this now, but I think that we could now make the diff even smaller by using AppserviceUserIdentity::maybe_add_to_uri() rather than OutgoingRequestAppserviceExt. We can just keep calling Client::send_customized_request() and replace the call to add_user_id_to_query with AppserviceUserIdentity::maybe_add_to_uri().

We just need to upgrade Ruma to the latest commit, and we will make another release before releasing this crate.

[rsb-tbg]

No apology necessary. Will check that out now

[zecakeh]

You can bump ruma to a git revision for now, so that this PR can pass CI.

[zecakeh]

Thanks, this looks good now. To be able to use ruma as a git dependency for now, we need to relax the cargo-deny config.

You need to modify .deny.toml:

• In the [bans] section, change

  wildcards = "warn"
  

• In the [sources] section, add

  allow-git = [
      "https://github.com/ruma/ruma",
  ]
  

[zecakeh]

Thanks a lot!