Improving the capture of nested data from set_stats #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ltamaster can you take a look at this and see if it can be merged? Thanks |
Contributor
Author
|
@fdevans can you take a look at this and see if it can be merged? Thanks |
Contributor
Author
|
@ltamaster or @fdevans can you please take a look at this pending issue? Thanks |
Contributor
Author
|
@ltamaster, @fdevans, @Jesus-Osuna-M could one of you please take a look at this ? Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first implementation of the set_stats logs filter only works with string values, if you provide an array or a dict the log filter fails since the method getAsString() only works for JsonPrimitive objects.
This commit uses the Gson class and its toJson() method to serialize the value, no matter if it's a JsonPrimitive, JsonObject, JsonArray or JsonNull.