-
Notifications
You must be signed in to change notification settings - Fork 98
RUN-4085 Generate Inventory with SSH password authentication #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0a8b7d to
70d64d2
Compare
enable the node auth just for workflow steps
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleDescribable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerContextBuilder.java
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/plugin/AnsiblePlaybookWorkflowStep.java
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerContextBuilder.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerContextBuilder.java
Show resolved
Hide resolved
...-import/ansible-multi-node-auth/rundeck-ansible-multi-node-auth/jobs/job-multi-node-ping.xml
Show resolved
Hide resolved
…i-node-auth/rundeck-ansible-multi-node-auth/jobs/job-multi-node-ping.xml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ner.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (2)
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerContextBuilder.java:1
- Corrected spelling of 'filesystem' to 'file system' (two words is more standard in comments).
/**
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunner.java:1
- Corrected spelling of 'filesystem' to 'file system' (two words is standard in comments).
package com.rundeck.plugins.ansible.ansible;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerContextBuilder.java
Show resolved
Hide resolved
functional-test/src/test/resources/docker/ansible-multi-node-auth/README.md
Outdated
Show resolved
Hide resolved
src/test/groovy/com/rundeck/plugins/ansible/ansible/AnsibleRunnerSpec.groovy
Show resolved
Hide resolved
…uth/README.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This pull request introduces comprehensive functional tests for the Ansible plugin's multi-node authentication feature, ensuring that each node can have its own credentials (password or private key) stored in Rundeck's key storage. It adds new test suites, supporting documentation, and Docker configurations to validate scenarios including password escaping, per-node authentication, and compatibility with current Rundeck versions.
Key changes include:
1. Functional Test Coverage for Multi-Node Authentication
MultiNodeAuthSpec.groovy, a Spock test suite that verifies multi-node authentication with different credentials per node (passwords and private keys), password escaping for special characters, and node accessibility. The suite includes helper methods for project setup, key storage, and job execution.2. Test Documentation and Usage Instructions
functional-test/README.mdexplaining prerequisites, Docker/Testcontainers setup, how to run tests, test structure, troubleshooting, and specifics of the multi-node authentication feature.docker/ansible-multi-node-auth/README.mddescribing the test setup, what is being tested, and expected behaviors.3. Docker and Test Resource Enhancements
docker-compose.ymlto add three new SSH test nodes (ssh-node-2,ssh-node-3,ssh-node-4) with unique passwords and private key authentication, and mounted the new test scenario directory. [1] [2]ansible.cfg), inventory (inventory.ini), node definitions (resources.xml), and a test playbook (test-playbook.yml) for the multi-node authentication scenario. [1] [2] [3] [4]4. Gradle and Test Environment Updates
These changes collectively provide robust, automated validation for the Ansible plugin's advanced authentication features, improving confidence in multi-node and mixed-auth scenarios.Generate Inventory with SSH password authentication