fix: command arguments need to be split #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the pod script execution where command arguments were being passed as a single string instead of being split into individual arguments. This ensures that inline scripts in pods receive properly formatted command-line arguments.
- Splits the RD_CONFIG_ARGUMENTS string into individual arguments using spaces as delimiters
- Changes from appending a single string to appending individual arguments to the exec_command list
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if 'RD_CONFIG_ARGUMENTS' in os.environ: | ||
| arguments = os.environ.get('RD_CONFIG_ARGUMENTS') | ||
| exec_command.append(arguments) | ||
| for arg in arguments.split(" "): |
There was a problem hiding this comment.
Using split(' ') will not handle arguments that contain spaces (even when quoted) or multiple consecutive spaces correctly. Consider using shlex.split() instead, which properly handles shell-style quoting and escaping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command arguments need to be split when invoking inline scripts in pods.