fix(datasets): improve Dataset.generate polling robustness and timeout handling#494
Draft
thiagobomfin-galileo wants to merge 1 commit intomainfrom
Draft
fix(datasets): improve Dataset.generate polling robustness and timeout handling#494thiagobomfin-galileo wants to merge 1 commit intomainfrom
thiagobomfin-galileo wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
+ Coverage 82.00% 82.03% +0.02%
==========================================
Files 96 96
Lines 9260 9273 +13
==========================================
+ Hits 7594 7607 +13
Misses 1666 1666 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
de47abb to
753441b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Shortcut:
NewSDK: extend() and generate() do NOT work
Description:
Summary
extension job, which caused Dataset.generate to return empty rows
detection: raises DatasetAPIException if steps_completed doesn't advance for 30 consecutive
seconds
the extend_dataset convenience function, replacing a hardcoded constant and preventing
infinite polling loops
API exposes one in JobProgress
exception behavior
Test plan
correctly
empty rows
progress
Tests:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Harden the
Datasets.extendandextend_datasetpolling loop with timeout, stall detection, and updated docstrings so synthetic extension jobs no longer return empty rows and surfaceDatasetAPIExceptionwhen stalled. TeachDataset.generateto forward the sametimeout_secondscontract so callers receive generated rows instead of empty lists, with regression tests covering zero-step starts, stalls, and timeouts.Dataset.generateto pass throughtimeout_secondsso that generated rows respect the new polling contract.Modified files (1)
Latest Contributors(1)
timeout_seconds, detecting 30s stalls before raisingDatasetAPIException, and documenting the new behavior, with regression tests covering zero-step starts, timeouts, and stalls.Modified files (2)
Latest Contributors(2)