Open
Conversation
Contributor
|
I can't see how I'd implement the Inputs property without used a List<> or an array as the backing store, so this shouldn't be a problem. |
Author
|
If I need the opposite of case "NotInInput":
return Expression.Not(Expression.Call(Expression.Constant(rule.Inputs.ToList()),
_miListContains.Value,
propExpression));Or maybe add a new boolean field called Negate on Rule class that would invoke |
Author
|
@jamescurran Do you think that this can be merged, do you need anything else from me? |
Author
|
@jamescurran Any update on if this change to support the JSON configuration provider can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to tweak the rule class to change Inputs field from IEnumerable to IList for compatibility w/ IConfiguration. I updated tests and also added section to README for details in use.