fix race conditions reading/writing datafile #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description and repro:
If several processes simultaneously try to read and write the datafile,
you may wind up with an empty datafile.
I noticed this when opening up many shells at once with `screen -c dev`,
where `dev` contains:
source /etc/screenrc
screen -t home
chdir /tmp
screen -t tmp1
screen -t tmp2
screen -t tmp3
screen -t tmp4
screen -t tmp5
In one or more of the screen windows I see
mv: cannot stat `/home/adamm/.j.tmp': No such file or directory
and I notice my datafile has been truncated.
|
I tried to use this on OSX, but apparently flock isn't available there. Any alternatives? |
Author
|
I don't know, sorry. :( |
Not sure if you really want to use this, but: http://stackoverflow.com/a/13343904/1306877 |
Owner
|
I'm not really trying to maintain this project. https://github.com/rupa/z/ is actively maintained, has better features, and doesn't suffer from this particular bug (anymore) :) (Sad that flock isn't available on OSX tho) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and repro:
If several processes simultaneously try to read and write the datafile,
you may wind up with an empty datafile.
I noticed this when opening up many shells at once with
screen -c dev,where
devcontains:In one or more of the screen windows I see
and I notice my datafile has been truncated.