Automatically create missing parent directories in _Z_DATA path#211
Open
silenc3r wants to merge 1 commit intorupa:masterfrom
Open
Automatically create missing parent directories in _Z_DATA path#211silenc3r wants to merge 1 commit intorupa:masterfrom
silenc3r wants to merge 1 commit intorupa:masterfrom
Conversation
Contributor
|
Could also |
dmd
reviewed
Oct 24, 2019
dmd
left a comment
dmd
left a comment
There was a problem hiding this comment.
I don't think we should be doing this; I believe it's more likely that the path is wrong than it's right but missing, and we should just fail correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parent directories of _Z_DATA don't exist we should automatically create them.