Fix "called Option::unwrap() on a None value" in ParserIterator#1843
Open
forzafedor wants to merge 2 commits intorust-bakery:mainfrom
Open
Fix "called Option::unwrap() on a None value" in ParserIterator#1843forzafedor wants to merge 2 commits intorust-bakery:mainfrom
Option::unwrap() on a None value" in ParserIterator#1843forzafedor wants to merge 2 commits intorust-bakery:mainfrom
Conversation
|
Worth mentioning I removed the panic source in my (bigger scope) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
In this example I had the following problem!
This happened because of extra calls to the
next()function andHere the
statevariable is set toNonebut is not set in these conditionsI think this behavior is incorrect.
In iterator std::iter.next() additional calls to the
nextfunction will returnNone. I think it would be logical for this iterator to have similar behavior.I fixed it and added tests for this example!
Please review MR you have time, thank you!