Fix latest clippy/rustc lints and release 0.11.1. #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only a few of these, and the lifetime ones are a compiler warning rather than a clippy warning (meaning that they will cause failures in my local CI) so fix them here.
apoelstra
force-pushed
the
2025-12/release-0.11.1
branch
from
c82cb05 to
527df49
Compare
clarkmoody
approved these changes
Dec 1, 2025
Member
clarkmoody
left a comment
clarkmoody
left a comment
There was a problem hiding this comment.
utACK 527df49
Looks like CI is still failing for some reason.
Member
Author
|
I'll just rerun the API checker and commit it. In rust-bitcoin we've pinned the version of cargo-public-api to avoid these sorts of problems but here it's probably okay to just leave it, at least for this old version. |
The output of cargo-public-api changed at some point.
apoelstra
force-pushed
the
2025-12/release-0.11.1
branch
from
527df49 to
d477dec
Compare
tcharding
approved these changes
Dec 1, 2025
Member
Author
|
cc @clarkmoody can you re-ACK? |
Member
Author
|
Tagged and published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest versions of rust-bitcoin and rust-elements depend on bech32 0.11.0. Unfortunately this has been hit by a recent breaking change in rustc rust-lang/rust#138907
Work around the break and cut a new version. While we're at it, fix all the recent lint changes (there are not many).