Provide a gdb pretty printer for smol_str::SmolStr #21011
+138
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
2 times, most recently
from
3712013 to
c58810b
Compare
Contributor
|
We had to force push, you need to rebase on master. |
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
from
c58810b to
ccc0856
Compare
Author
|
Done. |
lib/smol_str/src/lib.rs
Outdated
| } | ||
|
|
||
| #[debugger_visualizer(gdb_script_file = "gdb_smolstr_printer.py")] | ||
| mod smolstr_gdb_visualizer {} |
Contributor
There was a problem hiding this comment.
You can make it a crate-level attribute (#![debugger_visualizer(gdb_script_file = "gdb_smolstr_printer.py")]).
Author
There was a problem hiding this comment.
Thanks, I didn't know this existed.
Done.
ChayimFriedman2
approved these changes
Nov 23, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
I don't really have experience with gdb prettyprinters, but the code looks correct to me, and you reported it works, so 👍
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
from
ccc0856 to
474df6d
Compare
Auto-loaded via the debugger_visualizer attribute. Tested on smolstr's unittest: $ RUSTFLAGS="-C debuginfo=2 -C opt-level=0" cargo test -p smol_str --no-run $ rust-gdb target/debug/deps/test-a806b111557a7133 (gdb) break test::conversions (gdb) run (gdb) next (gdb) print s (and other locations in that file, to test the three cases: Inline, Static and Heap)
dfaure-kdab
force-pushed
the
wip/dfaure/smolstr_pretty_printer
branch
from
474df6d to
0e24a86
Compare
ChayimFriedman2
approved these changes
Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-loaded via the debugger_visualizer attribute. Tested on smolstr's unittest:
$ RUSTFLAGS="-C debuginfo=2 -C opt-level=0" cargo test -p smol_str --no-run $ rust-gdb target/debug/deps/test-a806b111557a7133 (gdb) break test::conversions
(gdb) run
(gdb) next
(gdb) print s
(and other locations in that file, to test the three cases: Inline, Static and Heap)