fix: consider let else block for variables and control flow #21071
+55
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
|
My preferred choice is neither; instead, implement functionality in the HIR layer to get all variables used by an expression/statement etc. This is the only way to cover all scenarios, including macros, well, and make sure such problems don't repeat with new language constructs. Of course, this is more work, so doing one of those is also fine. |
Contributor
Author
|
I'm okay with closing this PR and implementing in the HIR layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21039
I have to tried to fix this in two ways, one is of course the PR and other is this one: dfireBird@a83390f
I'm not sure which is good, so I'll change the PR accordingly as per review.