Skip to content

Conversation

@Aditya-PS-05
Copy link
Contributor

@Aditya-PS-05 Aditya-PS-05 commented Nov 22, 2025

closes #21091

Inlay hints were rapidly appearing and hiding while typing, making code unable to read. I moved the inlay hint refresh logic to trigger when the system becomes quiescent.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2025
@ChayimFriedman2
Copy link
Contributor

This shouldn't be the correct things to do. AFAIK that means we won't refresh inlay hints on changes, unless the quiescence status was changed.

But I'm not an expert in this part of the codebase, so I'll let someone else review it.

@Veykril
Copy link
Member

Veykril commented Nov 23, 2025

Inlay hints were rapidly appearing and hiding while typing,

Curious in which editor you observe this. Zed handles this fine, and in VSCode this works as well from what I recall.

@Aditya-PS-05
Copy link
Contributor Author

Inlay hints were rapidly appearing and hiding while typing,

Curious in which editor you observe this. Zed handles this fine, and in VSCode this works as well from what I recall.

I just tried to reproduce the original issue #21091 and when the inlay hints are longer is size, and we make some wrong changes, the inlay hints suddenly disappear making it harder to focus on writing.

@Veykril
Copy link
Member

Veykril commented Nov 23, 2025

I don't see how this change will fix that. It seems more like a vscode bug to me as the change here will just make us not refresh inlay hints at all in other files (which we need to do given how rust works)

@Veykril
Copy link
Member

Veykril commented Nov 23, 2025

So I'd recommend reporting this to VSCode as that sounds like a regression on their part

@Veykril Veykril closed this Nov 23, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2025
@Aditya-PS-05
Copy link
Contributor Author

@Veykril sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inlay hints rapidly spawning and despawning in VSCode, making code unreadable while typing

4 participants