Skip to content

Conversation

@xdBronch
Copy link
Contributor

this lets things be rendered with a strikethrough without needing any diagnostics
image

it can be set in vscode settings like so

    "editor.semanticTokenColorCustomizations": {
        "rules": {
            "*.deprecated": { "fontStyle": "strikethrough" }
        }
    },

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2025
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure, but I think I prefer to handle this for each variant in a common place instead of duplicating it all over, e.g. from the match over the definition return Option<AttrsWithOwner> as well, then check it after.

@xdBronch
Copy link
Contributor Author

sure i think that makes sense, the places we handle it become a little cleaner

Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Nov 23, 2025
Merged via the queue into rust-lang:master with commit 762b21c Nov 23, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2025
@xdBronch xdBronch deleted the deprecated-tokens branch November 23, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants