minor: Use const_eval_static query for statics
#21104
Merged
+171
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
veykril/push-plqyyxsxvtyr
branch
from
e0848ad to
f0ceac4
Compare
rustbot
removed
the
S-waiting-on-review
Veykril
force-pushed
the
veykril/push-plqyyxsxvtyr
branch
from
f0ceac4 to
66b6a1e
Compare
Contributor
|
This shouldn't consume a lot of memory as this is a small per-crate query, it also shouldn't speedup things a lot as it isn't called frequently, the real question is whether it will improve incrementality, and I don't think it will a lot. |
Member
Author
|
Yea a previous change made it so that trait_impls_in_deps was unqualified instead (which then requires this change), but that had horrendous runtime implications (for good reasons). So its probably not doing too much |
Veykril
force-pushed
the
veykril/push-plqyyxsxvtyr
branch
2 times, most recently
from
975c8fe to
c23b118
Compare
Veykril
changed the title
const_eval_static query for statics
Veykril
force-pushed
the
veykril/push-plqyyxsxvtyr
branch
from
c23b118 to
1a89e13
Compare
Veykril
force-pushed
the
veykril/push-plqyyxsxvtyr
branch
from
1a89e13 to
404fbd3
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have a tiny memory impac (scaling with number of statics used in const eval)