fix: no unused tracing/attributes feature
#21114
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lmmx
force-pushed
the
no-unused-tracing-attributes-feat
branch
from
76d2f44 to
748feab
Compare
- Discussed in rust-lang#21107 - Avoids activating an `attributes` feature to crates that do not use it - Updates the 6 crates that use attributes feature to specify it in their Cargo.toml: {hir,hir-def,hir-ty,ide-assists,ide-db,project-model}
lmmx
force-pushed
the
no-unused-tracing-attributes-feat
branch
from
748feab to
2443cce
Compare
Contributor
Author
|
All checks passing and rebased to trunk 🙂 Ready to merge @Veykril @ChayimFriedman2 |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attributesfeature to crates that do not use ittheir Cargo.toml: {hir,hir-def,hir-ty,ide-assists,ide-db,project-model}
tracing(implicitlydep:tracing) dependency from the parser cratedefaultfeature group (which now leaves it empty)