feat: Use annotate-snippets by default on nightly

[Muscraft]

This PR switches the default renderer to use annotate-snippets on nightly, but does not affect stable. This is part of the ongoing effort to use annotate-snippets to render all diagnostics.

MCP

Note: This contains the test change from #148004, without the change to the default emitter.

#59346
rust-lang/rust-project-goals#123

r? @davidtwco

[rustbot]

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

[Kobzol]

@bors try @rust-timer queue

Let's test perf outright :)

[estebank]

Wouldn't it be nicer to do

Suggested change

	match je.json_rendered {
	HumanReadableErrorType::AnnotateSnippet { short, unicode } => {
	AnnotateSnippetEmitter::new(dst, je.translator.clone())
	.short_message(short)
	.sm(je.sm.clone())
	.diagnostic_width(je.diagnostic_width)
	.macro_backtrace(je.macro_backtrace)
	.track_diagnostics(je.track_diagnostics)
	.terminal_url(je.terminal_url)
	.ui_testing(je.ui_testing)
	.ignored_directories_in_source_blocks(
	je.ignored_directories_in_source_blocks.clone(),
	)
	.theme(if unicode { OutputTheme::Unicode } else { OutputTheme::Ascii })
	.emit_diagnostic(diag, registry)
	}
	HumanReadableErrorType::Default { short } => {
	HumanEmitter::new(dst, je.translator.clone())
	.short_message(short)
	.sm(je.sm.clone())
	.diagnostic_width(je.diagnostic_width)
	.macro_backtrace(je.macro_backtrace)
	.track_diagnostics(je.track_diagnostics)
	.terminal_url(je.terminal_url)
	.ui_testing(je.ui_testing)
	.ignored_directories_in_source_blocks(
	je.ignored_directories_in_source_blocks.clone(),
	)
	.theme(OutputTheme::Ascii)
	.emit_diagnostic(diag, registry)
	}
	}
	let (short, unicode) = match je.json_rendered {
	HumanReadableErrorType::AnnotateSnippet { short, unicode } => (short, unicode),
	HumanReadableErrorType::Default { short } => (short, false),
	};
	HumanEmitter::new(dst, je.translator.clone())
	.short_message(short)
	.sm(je.sm.clone())
	.diagnostic_width(je.diagnostic_width)
	.macro_backtrace(je.macro_backtrace)
	.track_diagnostics(je.track_diagnostics)
	.terminal_url(je.terminal_url)
	.ui_testing(je.ui_testing)
	.ignored_directories_in_source_blocks(
	je.ignored_directories_in_source_blocks.clone(),
	)
	.theme(if unicode { OutputTheme::Unicode } else { OutputTheme::Ascii })
	.emit_diagnostic(diag, registry)

[Muscraft]

I have AnnotateSnippetEmitter and HumanEmitter split here so that users of nightly cargo would have their output rendered by AnnotateSnippetEmitter, since cargo uses the rendered field of the JSON diagnostic messages for its output.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 9642289 (9642289ca0cc666c0a012091ea4605836db294e4, parent: 9ea8d67cc60e88ad6fffbf299a454c44227e001c)

[rust-timer]

Finished benchmarking commit (9642289): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.3%, 0.9%]	12
Regressions ❌ (secondary)	0.4%	[0.1%, 1.1%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.3%, 0.9%]	12

Max RSS (memory usage)

Results (secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.4%, 4.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.628s -> 473.869s (-0.16%)
Artifact size: 390.61 MiB -> 390.65 MiB (0.01%)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.