Skip to content

MGCA: Const constructors support #150704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jan 6, 2026
Merged

MGCA: Const constructors support #150704

bors merged 1 commit into from
Jan 6, 2026
+254 −55

Conversation

@Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Jan 5, 2026 •
edited by BoxyUwU
Loading

part of #132980

fixes #132985
fixes #136138
fixes #139596

r? BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

HIR ty lowering was modified

cc @fmease

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

BoxyUwU
BoxyUwU reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@BoxyUwU BoxyUwU left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Can you add a test for const constructors using generic parameters, e.g. Option::None::<T> or Struct::<T>

View changes since this review

BoxyUwU
BoxyUwU reviewed Jan 5, 2026
View reviewed changes
@BoxyUwU BoxyUwU mentioned this pull request Jan 5, 2026
Open
29 tasks
Kivooeo
Kivooeo commented Jan 5, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the const-ctor branch 2 times, most recently from cf333f5 to e4c0415 Compare January 5, 2026 20:52
BoxyUwU
BoxyUwU approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@BoxyUwU BoxyUwU left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once #150640 lands

View changes since this review

@fmease
Copy link
Member

fmease commented Jan 6, 2026 •
edited
Loading

Did you really mean to link to issue #105952 in the PR description (esp. after keyword Fixes)? That issue was fixed 3 years ago & isn't related to the changes made in this PR.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 6, 2026

☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Jan 6, 2026

☔ The latest upstream changes (presumably #150640) made this pull request unmergeable. Please resolve the merge conflicts.

@Kivooeo
Copy link
Member Author

Kivooeo commented Jan 6, 2026

Did you really mean to link to issue #105952 in the PR description

Yes, because there were very similar test case in crashes with link to this issue which still ICEs, and this ICE was fixed by that PR

Removed link from description in case that will cause any confusion

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
BoxyUwU
BoxyUwU reviewed Jan 6, 2026
View reviewed changes
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Jan 6, 2026
@rust-cloud-vms rust-cloud-vms bot force-pushed the const-ctor branch 2 times, most recently from abd5747 to bfd4c97 Compare January 6, 2026 15:01
@BoxyUwU
Copy link
Member

BoxyUwU commented Jan 6, 2026

@bors r+ rollup

cool!

@bors
Copy link
Collaborator

bors commented Jan 6, 2026

📌 Commit d32f1c6 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 6, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 6, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150704 - Kivooeo:const-ctor, r=BoxyUwU
8d8deed 
MGCA: Const constructors support

part of rust-lang#132980

fixes rust-lang#132985
fixes rust-lang#136138
fixes rust-lang#139596

r? BoxyUwU
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 6, 2026
Closed
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150729 - matthiaskrgr:rollup-an2m4zg, r=matthiaskrgr
f0b7fcf 
Rollup of 4 pull requests

Successful merges:

 - #150026 (Fix macro_metavar_expr_concat behavior with nested repetitions)
 - #150521 (resolve: Rename "name bindings" to "name declarations")
 - #150704 (MGCA: Const constructors support)
 - #150728 (Cleanup some ui tests for const-traits)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Jan 6, 2026
@bors
Auto merge of #150729 - matthiaskrgr:rollup-an2m4zg, r=matthiaskrgr
0aced20 
Rollup of 4 pull requests

Successful merges:

 - #150026 (Fix macro_metavar_expr_concat behavior with nested repetitions)
 - #150521 (resolve: Rename "name bindings" to "name declarations")
 - #150704 (MGCA: Const constructors support)
 - #150728 (Cleanup some ui tests for const-traits)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c45483 into rust-lang:main Jan 6, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 6, 2026
rust-timer added a commit that referenced this pull request Jan 6, 2026
@rust-timer
Unrolled build for #150704
8051485 
Rollup merge of #150704 - Kivooeo:const-ctor, r=BoxyUwU

MGCA: Const constructors support

part of #132980

fixes #132985
fixes #136138
fixes #139596

r? BoxyUwU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.94.0

6 participants

@Kivooeo @rustbot @rust-log-analyzer @fmease @bors @BoxyUwU