Convert -Ctarget-cpu into a target-modifier for NVPTX
#150732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
kulst
changed the title
-Ctarget-cpu a target-modifier on NVPTX
Author
|
@rustbot label: +O-NVPTX |
rustbot
added
the
O-NVPTX
kulst
changed the title
-Ctarget-cpu a target-modifier on NVPTX-Ctarget-cpu into a target-modifier on NVPTX
kulst
changed the title
-Ctarget-cpu into a target-modifier on NVPTX-Ctarget-cpu into a target-modifier for NVPTX
For NVPTX `-Ctarget-cpu` needs to be the same in all crates linked together into a binary. This converts `-Ctarget-cpu` into a target-modifier. However, the agreement about it is only enforced when compiling for specific targets based on a flag in the target specification. This makes `-Ctarget-cpu` effectively a target-modifier only for NVPTX for which this flag is set.
kulst
force-pushed
the
cpu_is_target_modifier
branch
from
7164067 to
a8f5e96
Compare
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
Author
|
r? @bjorn3 as you suggested this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NVPTX
-Ctarget-cpuneeds to be the same in all crates linked together into a binary.This PR converts
-Ctarget-cpuinto a target-modifier. However, the agreement about it is only enforced when compiling for specific targets based on a flag in the target specification. This makes-Ctarget-cpueffectively a target-modifier only for NVPTX, for which this flag is set.Previous discussions about this topic can be found here and here.
I also created a Zulip discussion.
I am unsure if a MCP is needed before proceeding. If you think so please let me know.
Creating target-modifiers for NVPTX target-features is to be done in a follow-up.
cc @kjetilkjeka as target maintainer for NVPTX
cc @Flakebi as you might need the same feature for amdgpu
cc @RalfJung you were very involved in the discussions so far