Skip to content

Factorize triagebot.toml float parsing mentions with a glob matching #150738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Urgau wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Factorize triagebot.toml float parsing mentions with a glob matching #150738

Urgau wants to merge 2 commits into from
+37 −6

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Jan 6, 2026

@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026
@tgross35
Copy link
Contributor

tgross35 commented Jan 6, 2026

That's exactly what motivated my comment, thank you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 6, 2026

📌 Commit bd0d0f7 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Urgau
Copy link
Member Author

Urgau commented Jan 6, 2026

Let me fix tidy

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2026
@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

tgross35
tgross35 reviewed Jan 7, 2026
View reviewed changes
@Urgau Urgau force-pushed the triagebot-first-glob-use branch from 5046065 to 34c8556 Compare January 7, 2026 06:48
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 7, 2026
@Urgau Urgau force-pushed the triagebot-first-glob-use branch from 34c8556 to bbdba48 Compare January 7, 2026 17:28
tgross35
tgross35 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unless you want to wait on a review from somebody more familiar with triagebot

View changes since this review

@Urgau
Copy link
Member Author

Urgau commented Jan 7, 2026

No need to wait IMO, the code is pretty straightforward.

@bors r=tgross35 rollup

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit bbdba48 has been approved by tgross35

It is now in the queue for this repository.

Kobzol added a commit to Kobzol/rust that referenced this pull request Jan 7, 2026
@Kobzol
Rollup merge of rust-lang#150738 - triagebot-first-glob-use, r=tgross35
4cb5ccb 
Factorize `triagebot.toml` float parsing mentions with a glob matching

Related to rust-lang/triagebot#2244.

r? @tgross35
@Kobzol Kobzol mentioned this pull request Jan 7, 2026
Open
rust-bors bot added a commit that referenced this pull request Jan 7, 2026
@rust-bors
Auto merge of #150784 - Kobzol:rollup-0mvdoy5, r=Kobzol
548e586 
Rollup of 4 pull requests

Successful merges:

 - #150738 (Factorize `triagebot.toml` float parsing mentions with a glob matching)
 - #150761 (rustc book: fix grammar)
 - #150764 (Convert static lifetime to an nll var)
 - #150775 (Move issue-12660 to 'ui/cross-crate/ with a descriptive name)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Urgau @rustbot @tgross35 @bors @rust-log-analyzer