resolve: Use Macros20NormalizedIdent in more interfaces

[petrochenkov]

It allows to avoid expensive double normalization in some cases.
This is an attempt to fix the perf regressions from #149681.

[rustbot]

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[petrochenkov]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: e520b01 (e520b01b98bd6455f6d47eded6e6c5b14be22ce7, parent: 4d73a008eaf6ba3ca067a3221e5c00602e33a5f2)

[rust-timer]

Finished benchmarking commit (e520b01): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.6%, -0.1%]	120
Improvements ✅ (secondary)	-0.4%	[-1.1%, -0.1%]	55
All ❌✅ (primary)	-0.3%	[-0.6%, -0.1%]	120

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.709s -> 471.656s (-0.43%)
Artifact size: 390.82 MiB -> 390.89 MiB (0.02%)

[petrochenkov]

How often resolve_ident_in_scope_set is used with different scope sets:

Module:        1015781
All:            445512
Macro:          217256
ExternPrelude:     649

So, ScopeSet::Module is the new dominating mode of use for resolve_ident_in_scope_set, it's not surprising that it's stressing it.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[petrochenkov]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: d6b68ca (d6b68ca4b912a0e27bcdf1f604470687653b8d16, parent: d9617c8d9a55773a96b61ba3a4acb107d65615c1)

[rust-timer]

Finished benchmarking commit (d6b68ca): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-0.3%	[-0.6%, -0.1%]	116
Improvements ✅ (secondary)	-0.4%	[-1.2%, -0.1%]	53
All ❌✅ (primary)	-0.3%	[-0.6%, -0.1%]	116

Max RSS (memory usage)

Results (primary -1.2%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	3
Improvements ✅ (primary)	-1.2%	[-2.0%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-2.0%, -0.5%]	4

Cycles

Results (primary 3.0%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.1%, 3.9%]	2
Regressions ❌ (secondary)	2.4%	[1.3%, 3.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	3.0%	[2.1%, 3.9%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.542s -> 478.609s (0.86%)
Artifact size: 390.84 MiB -> 390.88 MiB (0.01%)

[petrochenkov]

The large-workspace regression is spurious (llvm codegen time regresses, which is unrelated to this PR).

[petrochenkov]

This recovers roughly a half of performance lost in #149681.
I have a couple more ideas about speeding up resolve_ident_in_scope_set, but I'm less sure in them and would rather benchmark them separately.

@rustbot ready
r? @nnethercote maybe?

[nnethercote]

@bors r+

[rust-bors]

📌 Commit 99a7d28 has been approved by nnethercote

It is now in the queue for this repository.