-
Notifications
You must be signed in to change notification settings - Fork 85
document combination of flags #756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixes #646 |
antoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
Here's a first review.
Thanks for your work!
Good points :), thanks! |
antoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry again for the long delay.
Thanks for your work!
Co-authored-by: antoyo <antoyo@users.noreply.github.com>
|
@FrancescoV1985: Would it be OK if @harin-ramesh continues your work of this PR? |
Hello. It is fine, thanks. Please re-assign. |
updated document
antoyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
With these changes, I believe this will be good to go.
Note: Please make a new PR and cherry-pick the commits in order to avoid having to ask the original author to merge a new PR against their fork. This should keep the author information in the commits.
|
Merged in #808. |
-Documented in CONTRIBUTING.md the role of sysroot and the meaning of different flags combination used in frontend script y.sh
-Updated help output for binary file y (build_system/target/release/y build --help)