Skip to content

Conversation

@FrancescoV1985
Copy link
Contributor

-Documented in CONTRIBUTING.md the role of sysroot and the meaning of different flags combination used in frontend script y.sh
-Updated help output for binary file y (build_system/target/release/y build --help)

@FrancescoV1985
Copy link
Contributor Author

Fixes #646

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.
Here's a first review.
Thanks for your work!

@FrancescoV1985
Copy link
Contributor Author

Sorry for the delay. Here's a first review. Thanks for your work!

Good points :), thanks!

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again for the long delay.
Thanks for your work!

Co-authored-by: antoyo <antoyo@users.noreply.github.com>
@antoyo
Copy link
Contributor

antoyo commented Nov 23, 2025

@FrancescoV1985: Would it be OK if @harin-ramesh continues your work of this PR?
Or do you prefer to finish this PR yourself?

@FrancescoV1985
Copy link
Contributor Author

@FrancescoV1985: Would it be OK if @harin-ramesh continues your work of this PR? Or do you prefer to finish this PR yourself?

Hello. It is fine, thanks. Please re-assign.

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
With these changes, I believe this will be good to go.
Note: Please make a new PR and cherry-pick the commits in order to avoid having to ask the original author to merge a new PR against their fork. This should keep the author information in the commits.

@antoyo
Copy link
Contributor

antoyo commented Nov 28, 2025

Merged in #808.
Thanks for your contribution!

@antoyo antoyo closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants