Add support for syncing GitHub App installation repos with GitHub app auth#2393
Draft
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Draft
Add support for syncing GitHub App installation repos with GitHub app auth#2393Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Conversation
Kobzol
requested review from
Mark-Simulacrum,
emilyalbini,
jdno,
marcoieni and
ubiratansoares
as code owners
Member
|
at the moment we use a PAT to apply sync-team, so why merging this? Unless we want to switch to a github app even for syncing now |
Member
Author
|
Well as you wrote in #1724 (comment), this is one of the next steps required to switch from a PAT to a GitHub App. We don't need to merge it, it doesn't really do anything at the moment on CI, but if we want to do the switch, we'll need this change eventually. I mostly opened it so that someone with an enterprise GH app token can test it out :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This won't currently be executed on CI, and I have no idea how to test this without a GH app enterprise write token.
So it has to be tested manually.
Context: #1724