Skip to content

relax github team members validation#2407

Merged
marcoieni merged 1 commit intomainfrom
relax-github-team-members-validation
Apr 13, 2026
Merged

relax github team members validation#2407
marcoieni merged 1 commit intomainfrom
relax-github-team-members-validation

Conversation

@marcoieni
Copy link
Copy Markdown
Member

@marcoieni marcoieni commented Apr 13, 2026

Sometimes GitHub usernames change and our CI fails.
With this PR, the CI fails only if the user is a member of a team (not alumni).

Manual test 1

  1. Change the username of a member (eg https://github.com/rust-lang/team/blob/main/people/maurer.toml )
    • Change the file name
    • Change the github field in the file
    • Change their username in any members section they appear.
  2. Run GITHUB_TOKEN=$(gh auth token) cargo run -- check

Output:

[ERROR rust_team::validate] validation error: GitHub user `maurer1` changed username to `maurer`
[ERROR rust_team] 1 validation errors found

Manual test 2

  1. Change a username of an alumni ( eg https://github.com/rust-lang/team/blob/main/people/J-ZhengLi.toml )
    • Change the file name
    • Change the github field in the file
    • Change their username in any alumni section they appear.
  2. Run the previous command

The output doesn't report errors

@github-actions
Copy link
Copy Markdown

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] synchronizing github

@marcoieni marcoieni force-pushed the relax-github-team-members-validation branch 2 times, most recently from 9bdd05b to cde909b Compare April 13, 2026 07:05
@marcoieni marcoieni force-pushed the relax-github-team-members-validation branch from cde909b to 3efe54d Compare April 13, 2026 07:07
Comment thread src/data.rs
}

/// Return the usernames of all active members, i.e. all members of non-alumni teams.
/// It also includes members of teams that don't have a `[[github]]` section.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preferred to include these teams in the validation because imo it is important that the usernames are up-to-date.
Eg https://github.com/rust-lang/team/blob/main/teams/android.toml

@marcoieni marcoieni marked this pull request as ready for review April 13, 2026 07:32
@marcoieni marcoieni added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit 7113332 Apr 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants