Add user account link to user-info cmd#2347
Merged
apiraino merged 1 commit intorust-lang:masterfrom Mar 18, 2026
Merged
Conversation
Member
|
I don't think that right. The parenthesis you proposed to add is for the first line of the bullet point. The weirdness is actually in the quoted snippet and is I think the result of us stripping all the markdown inside it. We were talking about keeping some formatting in #2338 (review), we could also keep the links. |
Contributor
Author
|
ah ok so it's something happening in the stripping phase of the text? |
Member
|
Yeah this is most likely caused by the stripping, the parentheses in the title are fine. |
Kobzol
reviewed
Mar 18, 2026
Co-authored-by: Jakub Beránek <berykubik@gmail.com>
apiraino
changed the title
Contributor
Author
I'm searching where to touch to fix this, maybe here? |
Kobzol
changed the title
Kobzol
approved these changes
Mar 18, 2026
Member
|
Yeah, there. Let's land the username link change first, and if you want to fix the links, do that in a new PR. |
Contributor
Author
|
thanks Jakub :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there's a missing parenthesis to close a markdown link when listing recent user comments, see:
r? @Kobzol