Skip to content

Refactor to minimize newtype struct & unsafe #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
luojia65 merged 8 commits into from
Nov 26, 2024
Merged

Refactor to minimize newtype struct & unsafe #9

luojia65 merged 8 commits into from
Nov 26, 2024

Conversation

@woshiluo
Copy link
Member

@woshiluo woshiluo commented Nov 18, 2024 •
edited
Loading

This pull request implement the following features or fixes:

  • Use const instead of static to make test run normally.
  • Refactor to avoid deserialize_newtype_struct as much as possible.
  • Refactor to use lead_slice and lead_str instead of create slice manually.

@woshiluo
fix: use const instead of static
c4574b4 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo woshiluo changed the title Refactor Refactor to minimize newtype struct Nov 18, 2024
@woshiluo
refactor: minimize deserialize_newtype_struct
6913268 
Also update example because we do not change fdt binary anymore.

Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo
fix: typo
7a05488 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo
refactor: remove unsafe in reg
45084e0 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo woshiluo changed the title Refactor to minimize newtype struct Refactor to minimize newtype struct & unsafe Nov 19, 2024
@woshiluo
refactor: minimize unsafe
ed66bb1 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>

fix: fmt

Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo woshiluo marked this pull request as ready for review November 19, 2024 18:58
@guttatus guttatus requested a review from luojia65 November 20, 2024 03:06
luojia65
luojia65 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@luojia65 luojia65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@woshiluo
feat: avoid option of Node::props and Node::nodes
6590276 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo
feat: add deserialize for Node
0b0e315 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@woshiluo
feat: add Node::get_prop for find prop
097e294 
Signed-off-by: Woshiluo Luo <woshiluo.luo@outlook.com>
@luojia65 luojia65 merged commit 6d152e0 into rustsbi:main Nov 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luojia65 luojia65 luojia65 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@woshiluo @luojia65