Refactoring, cross platform support#12
Open
jonlabelle wants to merge 1 commit intorvrsh3ll:masterfrom
jonlabelle:patch-1
Open
Refactoring, cross platform support#12jonlabelle wants to merge 1 commit intorvrsh3ll:masterfrom jonlabelle:patch-1
jonlabelle wants to merge 1 commit intorvrsh3ll:masterfrom
jonlabelle:patch-1
Conversation
- Default ChunkSize to a slightly larger file size, `4096` instead of `1024` - Use `Join-Path` instead of literal back-slashes in path to support non-Windows platforms - Rename `Reassemble-File` function to `Unsplit-File` - Create output directories if they don't exist - Remove mandatory requirement for OutputFilePrefix parameter, since there's already a default (`chunk`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4096instead of1024Join-Pathinstead of literal back-slashes in path to support non-Windows platformsReassemble-Filefunction toUnsplit-Filechunk)