Fix downloads and test-suites dirs not skipped during run sync#363
Merged
Fix downloads and test-suites dirs not skipped during run sync#363
Conversation
…n sync The skipDirs check in readRwxDirectoryEntries only matched prefixed paths like ".rwx/downloads", but when called via rwxDirectoryEntries (the path used for runs), relativeTo is set to the .rwx dir itself, so entry.Path is just "downloads". Add the unprefixed names when relativeTo is set so the skip works in both call paths. This bug was introduced in #159 which changed the relativeTo logic but didn't update the skipDirs values to match.
robinaugh
force-pushed
the
fix-skip-dirs-in-rwx-directory-sync
branch
from
e53979b to
e8835a6
Compare
jmsanders
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
rwx run, files in.rwx/downloadswere being included in the directory size calculation, causing runs to potentially fail with:The workaround was to manually delete the
.rwx/downloadsfolder before running.Summary
skipDirscheck inreadRwxDirectoryEntriesonly matched prefixed paths like.rwx/downloads, but when called viarwxDirectoryEntries(the code path used forrwx run),relativeTois set to the.rwxdir itself, soentry.Pathis justdownloads— the skip never matched."downloads","test-suites") toskipDirsso the skip works in both call paths.relativeTologic but didn't update theskipDirsvalues to match.Test plan
files_test.gothat creates a largedownloadsdir inside.rwxand verifies it doesn't count against the 5MiB size limitservice_run_test.goassertions to reflect thattest-suitesis now correctly excluded (matching the original intent from Load from the .rwx dir if it exists #158)