Skip to content

Adding custiomization options for timestamps. Closes #86#99

Open
set-killer wants to merge 1 commit intoryanfitz:masterfrom
set-killer:master
Open

Adding custiomization options for timestamps. Closes #86#99
set-killer wants to merge 1 commit intoryanfitz:masterfrom
set-killer:master

Conversation

@set-killer
Copy link

I couldn't make a lot of testing but it seams to work.
Sorry, I cannot provide automatic test for this feature.

@set-killer
Copy link
Author

@ryanfitz what do I need to complete this feature? Could you give me a hint?

This test fails because they expect type 'date' but they receive type 'alternatives', which cannot be converted to simple DynamoDB type 'DATE' . Here is example

{ id: { type: 'string', invalids: [ '' ] },
  createdAt: 
   { type: 'alternatives',
     alternatives: [ [Object], [Object], [Object] ] },
  updatedAt: 
   { type: 'alternatives',
     alternatives: [ [Object], [Object], [Object] ] } }

I think this failing test are going to be deprecated... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant