Added the ability to auto dismiss flash messages#17
Open
Emerson wants to merge 2 commits intoryanto:masterfrom
Open
Added the ability to auto dismiss flash messages#17Emerson wants to merge 2 commits intoryanto:masterfrom
Emerson wants to merge 2 commits intoryanto:masterfrom
Conversation
|
Any reason why this was never merged in? Certainly useful, and is a relatively standard feature for flash messages. |
Collaborator
Author
|
I think the lack of tests was the main reason? As mentioned above, I'm using it in production and haven't had any issues - but having proper tests would give us peace of mind. Looking at the Files changed tab, I'm also seeing area's where things could be done cleaner and more modularly... |
|
@Emerson Thanks for the update. |
Collaborator
Author
|
@Emerson I'll check it out, although we ended up going with ember-notify for our main app. Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the auto dismissing feature outlined in issue #16. It's a little rough around the edges, so I totally understand if we don't want to merge it in yet, but I wanted to get it on the radar.
I'm using this code in my app and everything has been smooth so far, but the fact that I was not able to write a proper test for this makes me sad
. I also have a hunch that some of the code could be written in a cleaner way.