PyPREP bad channel detection #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behinger
reviewed
Dec 9, 2025
| # run the ransac algo | ||
| pyprep_by_ransac: bool = False | ||
| # params for ransac, defaults to empty dict, i.e. pyprep defaults | ||
| pyprep_by_ransac_params: dict = dict() |
Member
There was a problem hiding this comment.
Ultimately we should have a useful default configuration. maybe the one defined in the original github-issue on mne-bids-pipeline is reasonable?
Member
There was a problem hiding this comment.
that's too bad then, if it fails misserably for us :(
We have to find our own defaults then.
Member
|
is there a report already on which function found which channel as bad? |
Member
|
please note that we (finally) created a new fork, which we will try to maintain in parallel to the official mne-bids-pipeline https://github.com/s-ccs/mne-bids-eyetracking-pipeline/ We can finish the PR here, and then merge it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds PyPREP bad channel detection functionality to the first data quality step in the mne-bids-pipeline, just after MEG maxfilter based detection