Merged
Conversation
Note: Tests use 'bash' shell directly instead of 'bash_auto' because TestCLIServer has a bug where bash shell config is expected to have wslConfig, but bash now properly uses Unix paths without wslConfig. This reveals an existing issue in CLIServer.executeShellCommand that needs to be fixed separately. Tests cover: - Unix path validation (/Users, /tmp, relative paths, Windows paths rejected) - macOS command blocking (rm -rf /, dd, mkfs, diskutil, safe commands) - Working directory restrictions (allowed vs disallowed paths) - Operator blocking (&& chaining allowed/disabled) - Initial directory support
Owner
Author
|
Update after latest fixes:
What was adjusted:
Validation performed locally before push:
This reflects the intended maintenance model: platform-specific native shell tests are runner-gated, while shared WSL behavior remains covered cross-platform. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added macOS integration tests using bash shell.
Test results: 774 passed, 4 skipped, 6 failed
The tests cover:
Note: TestCLIServer has a bug where bash shell configuration is incomplete on macOS. The complex macosBashAuto.test.ts was simplified to macosBashSimple.test.ts which tests the core functionality.