a few minor details in special_values.py #41293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 4e7490d; changes) is ready! 🎉 |
dcoudert
reviewed
Dec 15, 2025
|
|
||
| return ZZ(-1)**(n//2 + 1) * ZZ(2)**(n-1) * pi**n * bernoulli(n) / factorial(n) | ||
| return ZZ(-1)**(n // 2 + 1) * ZZ(2)**(n - 1) * pi**n * bernoulli(n) / factorial(n) | ||
| else: |
Contributor
There was a problem hiding this comment.
the else could be removed
| if n == 1: | ||
| return infinity | ||
| elif n == 0: | ||
| if n == 0: |
Contributor
There was a problem hiding this comment.
this test is redundant. we have checked before whether n < 0, n > 1 and n == 1. So it remains only 0, right ?
| return QuadraticBernoulliNumber(1-n, d)/(n-1) | ||
| elif n >= 1: | ||
| return QuadraticBernoulliNumber(1 - n, d) / (n - 1) | ||
| if n >= 1: |
Contributor
There was a problem hiding this comment.
do we really need to check n >= 1 ? we have already tested whether n <= 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just reading the code there and cleaning a little bit
📝 Checklist