RDF[] for libsingular, delegate ideal comparison and .divides() to singular
#41309
+199
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in refuse to compare two ideals that we don't know how to compare #41040, it was decided that ideal comparison should compare them by set inclusion. Ideals of ZZ[x]'s comparison becomes unimplemented.
This pull request implements it by delegating to Singular. This is similar to how inverse_mod currently delegate to Singular, see Make inverse_mod use Singular in a few cases #39743
Similarly,
.divides()of polynomials over ℤ delegate to Singular.Previously,
RDF[]andCDF[]can be represented by Singular command-line interface. This represents these polynomial rings in libsingular too for feature parity.The magic constant
15is just to match what you get using the singular interface.The correctness of the code can be verified by comparing with singular's source code. For example
shortfl.hcontainsand later
shortfl.cc:For
n_long_Ctype,gnumpc.cchas e.g.indicating the correct thing to do with the
numberpointer is to cast them togmp_complex*.📝 Checklist
⌛ Dependencies