refactor(ghost_text): handle multibyte characters and reduce render calls #2252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ghost text display with multibyte characters showing as gibberish. Was using byte offsets instead of character counts, now properly uses
strchars()andstrcharpart()for UTF-8 handling.Demo
Before:2025-11-14_12-25-59.mp4
After:
2025-11-14_12-27-10.mp4
Also addresses a few fixes for noice.nvim ; the ghost text did not appear in cmdline for some context, e.g.
:cd<Space>and an extra redraw was making the search highlighted text blinking.Refactored to keep only the event-driven architecture:
TextChangedIbut retainedCursorMovedIautocmd to prevent text shaking during typing.Overall this translate in a small performance improvements. The draw calls are reduced by 22-29% and total CPU time reduced by 9-95% depending on operation.
Performance benchmarks details
Typing
vim.fn.getcmdtypewith slow typing, fast typing, and extended 500-iteration test.Draw Preview Performance
Show Preview Performance