-
Notifications
You must be signed in to change notification settings - Fork 0
fix: textinput handlefocus and styles #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Test Result
|
| activeOpacity={1} | ||
| onPress={handleFocus} | ||
| disabled={editable ?? TextInputTheme.editable}> | ||
| disabled={!!editable}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be disabled={!editable}>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! You got the point
dfbb2ae to
dc0bafb
Compare
| <TouchableOpacity | ||
| style={[demoStyles.controlButton, hasSuccess && demoStyles.controlButtonSecondary]} | ||
| onPress={toggleSuccess} | ||
| > | ||
| <Text style={demoStyles.controlButtonText}> | ||
| {hasSuccess ? 'Remove Success' : 'Add Success'} | ||
| </Text> | ||
| </TouchableOpacity> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the this? I see it's just rendering the text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a useless button as well
dc0bafb to
3ca0f85
Compare
Summary
Features
Bugs
Check List
Proof of Completeness

OR Video linkTextInputDemo.mp4