Skip to content

feat: add Header component and theme #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add Header component and theme #64

wants to merge 4 commits into from

Conversation

@loc-nguyenthien
Copy link
Contributor

@loc-nguyenthien loc-nguyenthien commented Nov 9, 2023 •
edited
Loading

Summary

  • Adding Header component
  • Adding custom theme for Header

Features

Bugs

Check List

  • Your code builds clean without any errors or warnings.
  • Check coding convention.
  • Updated Storybook components and stories to reflect any changes made to the UI.
  • Test covers all edge cases and coverage is greater than or equal to 80%.

Proof of Completeness

Screenshot changes introduced

baonguyenhsts
baonguyenhsts suggested changes Nov 9, 2023
View reviewed changes
ledutu2
ledutu2 reviewed Nov 10, 2023
View reviewed changes
@ngochuyduong ngochuyduong self-requested a review November 10, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ledutu2 ledutu2 ledutu2 approved these changes

@ngochuyduong ngochuyduong ngochuyduong approved these changes

@honghoangsts honghoangsts Awaiting requested review from honghoangsts honghoangsts is a code owner

@anhle10051996 anhle10051996 Awaiting requested review from anhle10051996

@hoangSTS hoangSTS Awaiting requested review from hoangSTS hoangSTS is a code owner

@huydosgtech huydosgtech Awaiting requested review from huydosgtech huydosgtech is a code owner

@loido loido Awaiting requested review from loido loido is a code owner

@ThinhKimVo ThinhKimVo Awaiting requested review from ThinhKimVo ThinhKimVo is a code owner

@vunguyendhSTS vunguyendhSTS Awaiting requested review from vunguyendhSTS

+2 more reviewers

@baonguyenhsts baonguyenhsts baonguyenhsts approved these changes

@chungnguyenhoang chungnguyenhoang chungnguyenhoang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@loc-nguyenthien @baonguyenhsts @chungnguyenhoang @ledutu2 @ngochuyduong