Skip to content

Bump picomatch from 2.3.1 to 2.3.2 in /scripts#1065

Open
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/scripts/picomatch-2.3.2
Open

Bump picomatch from 2.3.1 to 2.3.2 in /scripts#1065
dependabot[bot] wants to merge 1 commit intomainfrom
dependabot/npm_and_yarn/scripts/picomatch-2.3.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Mar 26, 2026

Bumps picomatch from 2.3.1 to 2.3.2.

Release notes

Sourced from picomatch's releases.

2.3.2

This is a security release fixing several security relevant issues.

What's Changed

Full Changelog: micromatch/picomatch@2.3.1...2.3.2

Changelog

Sourced from picomatch's changelog.

Release history

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog and this project adheres to Semantic Versioning.

  • Changelogs are for humans, not machines.
  • There should be an entry for every single version.
  • The same types of changes should be grouped.
  • Versions and sections should be linkable.
  • The latest version comes first.
  • The release date of each versions is displayed.
  • Mention whether you follow Semantic Versioning.

Changelog entries are classified using the following labels (from keep-a-changelog):

  • Added for new features.
  • Changed for changes in existing functionality.
  • Deprecated for soon-to-be removed features.
  • Removed for now removed features.
  • Fixed for any bug fixes.
  • Security in case of vulnerabilities.

4.0.0 (2024-02-07)

Fixes

Changed

3.0.1

Fixes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Slinky Test Report

Last Run: 2026-03-25 22:35:43 CST (Duration: 39.009s)

  • Pass: 2921
  • Fail: 11
  • Total: 2932
  • Files Scanned: 36017

Failures by URL

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward Dependabot security bump with correct version, integrity hash, and license field.

Extended reasoning...

Overview

This PR modifies a single file (scripts/package-lock.json), bumping picomatch from 2.3.1 to 2.3.2. The diff is minimal: version string, resolved URL, integrity hash, and an added license field — all mechanically generated by Dependabot.

Security risks

The update addresses CVE-2026-33671 and CVE-2026-33672 in picomatch. The only flagged issue is a pre-existing condition where the root package-lock.json still pins picomatch 2.3.1; this is outside the scope of this PR and requires a separate Dependabot PR for the root package. No new security risks are introduced.

Level of scrutiny

This is a Dependabot-generated lockfile update scoped to a subdirectory (/scripts). No logic changes, no API surface changes, no new dependencies. The correct level of scrutiny is low — this is a routine security patch on a dev dependency.

Other factors

No prior reviews exist on this PR. The one bug flagged is explicitly pre-existing and unrelated to the changes here. The PR is correct within its stated scope and safe to merge.

Comment on lines 699 to 709
}
},
"node_modules/picomatch": {
"version": "2.3.1",
"resolved": "https://registry.npmjs.org/picomatch/-/picomatch-2.3.1.tgz",
"integrity": "sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==",
"version": "2.3.2",
"resolved": "https://registry.npmjs.org/picomatch/-/picomatch-2.3.2.tgz",
"integrity": "sha512-V7+vQEJ06Z+c5tSye8S+nHUfI51xoXIXjHQ99cQtKUkQqqO1kO/KCJUfZXuB47h/YBlDhah2H3hdUGXn8ie0oA==",
"dev": true,
"license": "MIT",
"engines": {
"node": ">=8.6"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟣 This is a pre-existing issue: the root-level package-lock.json (at the repo root, not in /scripts) still locks node_modules/picomatch to the vulnerable version 2.3.1 (integrity sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==). This PR is correct for its stated scope (/scripts), but a separate Dependabot PR or manual update is needed to bump picomatch in the root package-lock.json and fully remediate CVE-2026-33671 and CVE-2026-33672 across the entire repo.

Extended reasoning...

Analysis

This PR correctly updates scripts/package-lock.json to resolve picomatch from 2.3.2 instead of the vulnerable 2.3.1. Dependabot scopes its PRs per package directory, so this PR only touches /scripts/package-lock.json, which is expected behavior.

However, the repo has a second, independent package-lock.json at the repository root (/package-lock.json). Examination of that file confirms node_modules/picomatch is still pinned to version 2.3.1 with the vulnerable integrity hash sha512-JU3teHTNjmE2VCGFzuY8EXzCDVwEqB2a8fsIvwaStHhAWJEeVd1o1QD80CU6+ZdEXXSLbSsuLwJjkCBWqRQUVA==.

Why existing code does not prevent this

Dependabot treats each package.json/package-lock.json pair in its own directory as an independent project. This PR was generated specifically for the /scripts subdirectory. The root-level lockfile is a separate project that requires its own Dependabot alert and PR. Nothing in this PR modifies or revalidates the root lockfile.

Impact

Any developer (or CI pipeline) running npm ci or npm install from the repository root will continue to install the vulnerable picomatch 2.3.1. Both CVE-2026-33671 and CVE-2026-33672 remain exploitable in the root project. Merging this PR alone may create a false sense that the CVEs are fully remediated when they are not.

Step-by-step proof

  1. Developer clones the repo after this PR merges.
  2. They run npm ci from the repo root (not from /scripts).
  3. npm reads /package-lock.json, which specifies node_modules/picomatch at version 2.3.1 with the old integrity hash.
  4. npm downloads and installs picomatch 2.3.1, the version vulnerable to CVE-2026-33671 and CVE-2026-33672.
  5. The /scripts subdirectory lockfile is unaffected by this root-level install.

Pre-existing classification

This issue is pre-existing and entirely unrelated to the changes in this PR. The PR does not introduce, worsen, or interact with the root lockfile in any way. A separate Dependabot PR targeting the root package.json (or a manual npm update picomatch from the root followed by committing the updated package-lock.json) is the correct remediation path. One verifier noted bug_002 is a duplicate of bug_001 tracking the same issue, which is correct—they both describe the same missing root-level fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Development

Successfully merging this pull request may close these issues.

0 participants