Skip to content

SAK-51713 Tests & Quizzes Instructors should see all student submissions when a assessment is published to the entire site#281

Open
st-manu wants to merge 1 commit intosakaiproject:masterfrom
st-manu:SAK-51938
Open

SAK-51713 Tests & Quizzes Instructors should see all student submissions when a assessment is published to the entire site#281
st-manu wants to merge 1 commit intosakaiproject:masterfrom
st-manu:SAK-51938

Conversation

@st-manu
Copy link
Contributor

@st-manu st-manu commented Dec 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated database schema for MySQL and Oracle environments to support lesson builder page management features.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 18, 2025

Walkthrough

A new hiddenFromNavigation column is added to the lesson_builder_pages table in both MySQL and Oracle database conversion scripts. The column uses platform-specific types (bit(1) for MySQL, number(1,0) for Oracle) with default value 0.

Changes

Cohort / File(s) Change Summary
Database Schema Updates
docs/conversion/sakai_26_mysql_conversion.sql, docs/conversion/sakai_26_oracle_conversion.sql
Adds new hiddenFromNavigation column to lesson_builder_pages table with platform-specific type configurations and default value 0

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title references SAK-51713 regarding Tests & Quizzes instructor visibility, but the actual changes add a hiddenFromNavigation column to lesson_builder_pages (SAK-51938), which is unrelated to the stated objective. Update the PR title to accurately reflect the changes: something like 'SAK-51938 Add hiddenFromNavigation column to lesson_builder_pages' to match the actual database schema modifications.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ee38228 and f9d771f.

📒 Files selected for processing (2)
  • docs/conversion/sakai_26_mysql_conversion.sql (1 hunks)
  • docs/conversion/sakai_26_oracle_conversion.sql (1 hunks)
🔇 Additional comments (2)
docs/conversion/sakai_26_mysql_conversion.sql (1)

25-27: Verify JIRA ticket consistency and update PR title if needed.

The code references SAK-51938 for adding a hiddenFromNavigation column to lesson_builder_pages. Please confirm this matches the PR's intended scope—if the PR title references a different ticket (SAK-51713), align the code comment or PR title accordingly.

Additionally, consider adding NOT NULL to ensure this boolean flag always has a defined state:

-alter table lesson_builder_pages add column hiddenFromNavigation bit(1) default 0;
+alter table lesson_builder_pages add column hiddenFromNavigation bit(1) default 0 not null;
docs/conversion/sakai_26_oracle_conversion.sql (1)

32-34: No changes required—this code is correct.

Both the MySQL and Oracle conversion scripts correctly implement SAK-51938 (Lesson Builder navigation feature). The commit history confirms this is the intended change. Both scripts consistently omit the NOT NULL constraint, and the type difference between platforms (MySQL bit(1) vs. Oracle number(1,0)) is appropriate.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant