Use html-to-text instead of html2plaintext package#19
Open
johncaruso wants to merge 2 commits intosalcosta:masterfrom
Open
Use html-to-text instead of html2plaintext package#19johncaruso wants to merge 2 commits intosalcosta:masterfrom
johncaruso wants to merge 2 commits intosalcosta:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@salcosta, the html2plaintext package was not preserving PRE block in the scripts background response (for sn_sync.evalScript command). All new lines in the output were removed, which is not desirable.
I swapped in a better package to convert html to text. It preserves the PRE block new lines. It also outputs the link for the execution history which can be useful if rollback is needed.
There were security vulnerabilities in a lodash dependency, so that's been upgraded as well.