test(wtr): windows compat, kinda #5578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't delete SauceLabs tho (yet)
It's implicit in the files being in the test directory and long filenames cause problems on windows
easier to maintain and uncovered a few broken tests!
and everywhere
is SAUCE defined in CI?
This reverts commit e4279e3.
lpomerleau
approved these changes
Nov 5, 2025
Comment on lines
-50
to
-53
| .catch((err) => { | ||
| console.error(err); | ||
| process.exit(1); | ||
| }); |
There was a problem hiding this comment.
was this removed b/c it's redundant?
Contributor
Author
There was a problem hiding this comment.
Yep. Changing to a top-level await accomplishes the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I did a lot of fiddling in #5548 to get integration tests to run on windows. I ended up abandoning that for our CI, but these changes are still good to have if we ever do want to explore that path.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item