Skip to content

fix: sfCLI parameter #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nrkruk merged 4 commits into from
Nov 21, 2024
Merged

fix: sfCLI parameter #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
845e58c
fix: typescript errors not showing in CI
nrkruk Nov 20, 2024
ca6c859
check if CI catches error
nrkruk Nov 20, 2024
9826284
fix: typescript error
nrkruk Nov 20, 2024
1f48346
chore: don't need this
nrkruk Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/failureNotifications.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: failureNotifications
on:
workflow_dispatch:
# workflow_run:
# workflows:
# - publish
# - create-github-release
# types:
# - completed
workflow_run:
workflows:
- publish
- create-github-release
types:
- completed
jobs:
failure-notify:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions src/commands/lightning/dev/site.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import fs from 'node:fs';
import { SfCommand, Flags } from '@salesforce/sf-plugins-core';
import { Messages } from '@salesforce/core';
import { expDev, setupDev } from '@lwrjs/api';
import { expDev, LocalDevOptions, setupDev } from '@lwrjs/api';
import { OrgUtils } from '../../../shared/orgUtils.js';
import { PromptUtils } from '../../../shared/promptUtils.js';
import { ExperienceSite } from '../../../shared/experience/expSite.js';
Expand Down Expand Up @@ -80,8 +80,8 @@ export default class LightningDevSite extends SfCommand<void> {

// Start the dev server
const port = parseInt(process.env.PORT ?? '3000', 10);
const startupParams = {
sfCli: true,
const startupParams: LocalDevOptions = {
sfCLI: true,
authToken,
open: true,
port,
Expand Down