Skip to content

Remove Robolectric shadows-playservices dependency#362

Open
MGaetan89 wants to merge 1 commit intosaltedge:masterfrom
MGaetan89:remove_robolectric_shadows-playservices
Open

Remove Robolectric shadows-playservices dependency#362
MGaetan89 wants to merge 1 commit intosaltedge:masterfrom
MGaetan89:remove_robolectric_shadows-playservices

Conversation

@MGaetan89
Copy link

Related Issue

N/A

Proposed Changes

  • Remove the org.robolectric:shadows-playservices dependency as it may not be necessary.

Additional Info

I am going through projects using the org.robolectric:shadows-playservices dependency, to see if it is possible to remove it. It seems that it may not be needed in this project.

NOTE

I wasn't able to get the Realm dependency locally, so I couldn't test my change before creating the PR.

@cla-bot
Copy link

cla-bot bot commented Mar 22, 2025

Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet.

@MGaetan89
Copy link
Author

I've filled the CLA form.

@cla-bot
Copy link

cla-bot bot commented Mar 24, 2025

Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet.

@ConstantinKV
Copy link
Collaborator

Thank you. Will check locally.

@MGaetan89 MGaetan89 force-pushed the remove_robolectric_shadows-playservices branch from 178bef7 to 899a351 Compare April 14, 2025 05:07
@cla-bot
Copy link

cla-bot bot commented Apr 14, 2025

Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet.

@MGaetan89
Copy link
Author

@ConstantinKV did you manage to have a look?

I am going through projects using the `org.robolectric:shadows-playservices` dependency, to see if it is possible to remove it. It seem that it may not be needed in this project.
@MGaetan89 MGaetan89 force-pushed the remove_robolectric_shadows-playservices branch from 899a351 to 923b38f Compare August 4, 2025 07:02
@cla-bot
Copy link

cla-bot bot commented Aug 4, 2025

Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet.

@MGaetan89
Copy link
Author

@ConstantinKV I've updated the PR with the latest changes from master.

@MGaetan89
Copy link
Author

Robolectric 4.16 has been released without the shadows-playservices module.
Let me know if I need to make any change to this PR in order to have it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants