Remove Robolectric shadows-playservices dependency#362
Remove Robolectric shadows-playservices dependency#362MGaetan89 wants to merge 1 commit intosaltedge:masterfrom
shadows-playservices dependency#362Conversation
|
Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet. |
|
I've filled the CLA form. |
|
Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet. |
|
Thank you. Will check locally. |
178bef7 to
899a351
Compare
|
Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet. |
|
@ConstantinKV did you manage to have a look? |
I am going through projects using the `org.robolectric:shadows-playservices` dependency, to see if it is possible to remove it. It seem that it may not be needed in this project.
899a351 to
923b38f
Compare
|
Thank you for your pull request and welcome to our Salt Edge community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MGaetan89 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added, in case you have already signed CLA and not been added yet. |
|
@ConstantinKV I've updated the PR with the latest changes from |
|
Robolectric 4.16 has been released without the |
Related Issue
N/A
Proposed Changes
org.robolectric:shadows-playservicesdependency as it may not be necessary.Additional Info
I am going through projects using the
org.robolectric:shadows-playservicesdependency, to see if it is possible to remove it. It seems that it may not be needed in this project.NOTE
I wasn't able to get the Realm dependency locally, so I couldn't test my change before creating the PR.