Skip to content

Use prefix for custom event names #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use prefix for custom event names #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e95116
Use prefix for custom event names
chemerisuk Mar 4, 2021
ddf8332
Fix error handling in fetch wrapper
chemerisuk Mar 30, 2021
383c550
Drop custom event prefix, make error event not to bubble
chemerisuk May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/js/utils/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ export function triggerEvent(element, type = '', bubbles = false, detail = {}) {
if (!is.element(element) || is.empty(type)) {
return;
}
// error event should not bubble and break error tracking tools
// https://developer.mozilla.org/en-US/docs/Web/API/Element/error_event
if (type === 'error') {
bubbles = false;
}

// Create and dispatch the event
const event = new CustomEvent(type, {
Expand Down
2 changes: 1 addition & 1 deletion src/js/utils/fetch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function fetch(url, responseType = 'text') {
});

request.addEventListener('error', () => {
throw new Error(request.status);
reject(new Error(request.status));
});

request.open('GET', url, true);
Expand Down