Skip to content

Conversation

@songmichael11
Copy link
Contributor

Description

Added the filter sidebar! With most functionality and syncing with the header filters. Also refactored some of the filters for reusability. Also changed the placement of the job comparator button to more closely align with the figma.

"On the job" functionality DOES NOT WORK RN BTW need to first potentially make schema changes again
Also it doesn't align like 100% with the figma but will change later

Motivation and Context

Closes #291

How has this been tested?

played around with it lol

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Database migration
    • Ran pnpm db:generate and verified generated SQL migration files in packages/db/drizzle

Checklist:

  • My code follows the code style of this project.
  • I have moved the ticket to "In Review"
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
cooper Ready Ready Preview, Comment Dec 31, 2025 7:46pm
2 Skipped Deployments
Project Deployment Review Updated (UTC)
cooper-auth Skipped Skipped Dec 31, 2025 7:46pm
cooper-docs Skipped Skipped Dec 31, 2025 7:46pm

@github-actions github-actions bot requested review from suxls and tracyyh December 30, 2025 04:16
Copy link
Collaborator

@gpalmer27 gpalmer27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just putting all of my thoughts here, some of it will be super nitpicky, my apologies:

  • For the chips at the top, in the figma then the 'all' chip doesn't have a number next to it, do we want to remove the number in the filters sidebar and on the regular sidebar or should we keep it
  • I think the padding is a bit off for the search bar and selected results for industry + location
Screenshot 2026-01-01 at 1 14 28 PM
  • idk if this is intended behavior but shouldn't the results be right under the search bar instead of under the things already selected?
  • The text for the 'clear all' + show results at the bottom should match the figma (darker color)
  • numbers should be a bit bigger for company culture
  • company culture and overtime work shouldn't have a clear, also make the text exactly match the figma for "overtime commonly expected"
  • let's try to get the bottom part working ideally before the new devs come so that we don't have to start the semester with schema mismatches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Develop) Filters sidebar

3 participants