[Full-Stack] Positions Cleanup #143

LOTaher · 2026-01-03T21:08:33Z

[Full-Stack] - Positions Cleanup

Changes

Extracted away data model related fetch calls in hooks to lib/api/*.
Added get positions by organization ID route at GET /api/positions?orgId=...
Removed positions/action.ts and replaced it with endpoints in /api/positions/route.ts
Made position creation throw on duplicate position names
Cleaned up props and modals on the position related pages
Removed error toasts and now using error text similar to the position create modal to keep everything consistent
Fixed a few error utilities

Screenshots

Checklist

Please go through all items before requesting reviewers:

Closes

Closes #127

vercel · 2026-01-03T21:08:37Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
sarge	Ready	Preview, Comment	Jan 7, 2026 4:07am

src/app/api/positions/[id]/candidates/csv/route.ts

src/app/api/positions/[id]/preview/route.ts

bderbs30 · 2026-01-07T16:20:31Z

src/lib/api/assessments.ts

@@ -0,0 +1,66 @@
+import { type AssessmentWithRelations } from '@/lib/services/assessment.service';


I think it'd be good to define the types within the types directory - thoughts?

Sure thing. Will fix, thanks

bderbs30 · 2026-01-07T21:18:53Z

src/lib/api/organizations.ts

@@ -0,0 +1,48 @@
+import {


I see this is related to abstracting away the fetch calls from hooks can u explain the reasoning for doing it this way

bderbs30 · 2026-01-07T22:48:14Z

src/lib/components/core/PositionsContent.tsx


                <TabsContent value="active" className="flex flex-col gap-4">
-                    {positions.length > 0 ? (
+                    {active.length > 0 ? (


when we say active are we referring to the active tab selected or the positions that are active / live

bderbs30 · 2026-01-07T22:50:56Z

src/lib/components/modal/CreateCandidateModal.tsx

+
+        handleCreate,
+        handleCancel,
+    } = useCreateCandidateModal({


https://www.reddit.com/r/reactjs/comments/xwzptl/whats_your_opinion_on_extracting_all_or_most/

I see we're extracting logic for state and effect to these hooks - ig this is up to us but is this common?

I think its clean but also might be overabstracting things that aren't going to be used elsewhere

ig in the future if we decide to have a create candidate modal functionality elsewhere then this might be helpful

bderbs30 · 2026-01-07T22:53:26Z

src/app/(web)/crm/positions/actions.ts

Yeah we can move away from actions if its something people aren't a hundo on

we can do similar things with tanstack query I believe

bderbs30 · 2026-01-07T22:56:39Z

src/lib/components/modal/CreatePositionModal.tsx

+export interface CreatePositionModalProps {
    open: boolean;
    onOpenChange: (open: boolean) => void;
+    setActive: React.Dispatch<React.SetStateAction<PositionWithCounts[]>>;


did we move away from useState to use the dispatch? If we did, what is the reasoning (not familiar with dispatch)

bderbs30 · 2026-01-07T23:00:27Z

src/lib/hooks/useCandidateTable.ts

@@ -0,0 +1,29 @@
+import type { PositionPreviewData } from './usePositionPreviewModal';
+
+export type Candidate = NonNullable<PositionPreviewData>['candidates'][number];


Why do we have to define it as NonNullable? Were there typing issues otherwise?

bderbs30 · 2026-01-08T01:32:49Z

src/lib/hooks/useCandidates.ts

-            toast.error('Batch creation failed');
+        } catch (err) {
+            const message = err instanceof Error ? err.message : 'Batch creation failed';
+            console.error(err);


we should remove this console error before we merge :)

bderbs30 · 2026-01-08T01:33:38Z

src/lib/hooks/useCandidates.ts

-            setError('Failed to batch create candidates');
-            toast.error('Batch creation failed');
+        } catch (err) {
+            const message = err instanceof Error ? err.message : 'Batch creation failed';


why do we need to check the instance I'm assuming its because you do err.message so we need to check the type of the err object right?

bderbs30 · 2026-01-08T01:35:36Z

src/lib/hooks/useCreatePositionModal.ts

+
+            // In the future we may want to add the ability to create a position AND upload a CSV
+            // of candidates at the same time. If that were the case, we'd want to create a new
+            // route to create a position with the count fields included in the returned object


In this case we could have it create the position and then update it - so it'd be two calls rather than a single create

we would then be using previous logic

thoughts?

LOTaher added 2 commits January 3, 2026 13:18

fix: abstract existings modal logic into hooks (#127)

8102a7e

add todo

f4d639e

LOTaher force-pushed the 127/position-creation-toasts branch from 76fa914 to f4d639e Compare January 3, 2026 21:21

vercel bot had a problem deploying to Preview January 3, 2026 21:22 Failure

LOTaher added 3 commits January 6, 2026 20:08

chore: abstract fetch calls away from hooks

8cffac7

feat: add 'archived' field to positions

44e87f2

fix: fix modal props and behavior

76f64e9

vercel bot had a problem deploying to Preview January 7, 2026 01:10 Failure

fix: prettier

ec29c1d

vercel bot had a problem deploying to Preview January 7, 2026 01:16 Failure

fix: lint

f96ec8d

vercel bot had a problem deploying to Preview January 7, 2026 01:18 Failure

fix: function rename

34b8d68

vercel bot had a problem deploying to Preview January 7, 2026 01:21 Failure

fix: type issues

0aa7169

vercel bot deployed to Preview January 7, 2026 01:47 View deployment

LOTaher changed the title ~~127/position creation toasts~~ [Full-Stack] Positions Cleanup Jan 7, 2026

fix: margin nit

592815b

LOTaher marked this pull request as ready for review January 7, 2026 02:30

vercel bot deployed to Preview January 7, 2026 02:30 View deployment

LOTaher added 3 commits January 6, 2026 23:04

fix: more position logic and csv fixes

1a5f432

fix: prettier + lint

dd6b2d8

fix: lint

28297ff

vercel bot deployed to Preview January 7, 2026 04:07 View deployment

LOTaher requested review from Anzhuo-W, bderbs30 and cherman23 and removed request for bderbs30 and cherman23 January 7, 2026 04:07

LOTaher requested review from ahweigl, bderbs30, cherman23 and mshvartsberg January 7, 2026 04:07

bderbs30 reviewed Jan 7, 2026

View reviewed changes

src/app/api/positions/[id]/candidates/csv/route.ts Show resolved Hide resolved

bderbs30 reviewed Jan 7, 2026

View reviewed changes

src/app/api/positions/[id]/preview/route.ts Show resolved Hide resolved

bderbs30 reviewed Jan 7, 2026

View reviewed changes

bderbs30 reviewed Jan 8, 2026

View reviewed changes

		@@ -0,0 +1,66 @@
		import { type AssessmentWithRelations } from '@/lib/services/assessment.service';

		@@ -0,0 +1,29 @@
		import type { PositionPreviewData } from './usePositionPreviewModal';

		export type Candidate = NonNullable<PositionPreviewData>['candidates'][number];

[Full-Stack] Positions Cleanup #143

Are you sure you want to change the base?

[Full-Stack] Positions Cleanup #143

Uh oh!

Conversation

LOTaher commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

[Full-Stack] - Positions Cleanup

Changes

Screenshots

Checklist

Closes

Uh oh!

vercel bot commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bderbs30 Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bderbs30 Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LOTaher commented Jan 3, 2026 •

edited

Loading

vercel bot commented Jan 3, 2026 •

edited

Loading

bderbs30 Jan 7, 2026 •

edited

Loading

bderbs30 Jan 8, 2026 •

edited

Loading