Add packetSnrRaw method to avoid floating-point
#570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some microcontrollers cannot use their floating-point coprocessor during interrupts (e.g. ESP32) which means they can't use the packetSnr method. packetSnrRaw allows the user to forgo the `* 0.25` in such cases
|
Could you use bit shift instead of the division - https://stackoverflow.com/questions/13577174/can-anyone-explain-why-2-shift-means-divided-by-4-in-c-codes? |
|
My thought is to leave it up to the user. I would like to keep the full precision of it, but I'd accept the loss of 2 bits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is motivated by a well known (#459, #460) limitation, that ESP microcontrollers can't use
float LoRa.packetSnr()in ISR because that method performs a floating point operation.My proposed solution is to add a method
int LoRa.packetSnrRaw()that returns theREG_PKT_SNR_VALUEregister as anintunmodified, rather than as a float divided by 4. I've written documentation for it noting that since it forgoes the division by 4, its value is 4 times the actual SNR.